Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test-code #534

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Improve test-code #534

merged 2 commits into from
Mar 16, 2024

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Mar 16, 2024

I noticed a strange bit of code.

Is there a reason for the 2nd if smile_version: guard?

@bouwew bouwew requested a review from a team as a code owner March 16, 2024 09:52
@bouwew bouwew requested a review from CoMPaTech March 16, 2024 09:52
Copy link

sonarcloud bot commented Mar 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bb67884) to head (6d85d08).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #534   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         3162      3161    -1     
=========================================
- Hits          3162      3161    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There probably once was, can't recall or endorse it now

@bouwew bouwew merged commit 04388e6 into main Mar 16, 2024
16 checks passed
@bouwew bouwew deleted the test-fix branch March 16, 2024 11:05
@bouwew bouwew mentioned this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants