Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement limited access to gateway modes for Adam #486

Merged
merged 13 commits into from
Dec 27, 2023
Merged

Implement limited access to gateway modes for Adam #486

merged 13 commits into from
Dec 27, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Dec 27, 2023

Implements feature request #523

@bouwew bouwew requested a review from a team as a code owner December 27, 2023 13:50
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a937a7b) 100.00% compared to head (7808055) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #486   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         2596      2643   +47     
=========================================
+ Hits          2596      2643   +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouwew
Copy link
Contributor Author

bouwew commented Dec 27, 2023

Not fixing the remaining Sonarcloud issue. Will be fixed when we split the code for legacy and non-legacy.

Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should review the if statements, but other than that, seems solid to me.

plugwise/__init__.py Show resolved Hide resolved
@CoMPaTech
Copy link
Member

Not fixing the remaining Sonarcloud issue. Will be fixed when we split the code for legacy and non-legacy.

I just login to sonar and set it to 'won't fix' with remark Known issue - that relieves the complexity (for now)

Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bouwew bouwew merged commit aca4bfc into main Dec 27, 2023
16 checks passed
@bouwew bouwew deleted the pauze_3 branch December 27, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants