Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split testing - initial split #483

Merged
merged 23 commits into from
Dec 24, 2023
Merged

Split testing - initial split #483

merged 23 commits into from
Dec 24, 2023

Conversation

CoMPaTech
Copy link
Member

Split testing into separate files (improving maintenance & less lengthy monolith file) als dropping 'smile' as that's default for this repo

@CoMPaTech CoMPaTech added the enhancement New feature or request label Dec 23, 2023
@CoMPaTech CoMPaTech self-assigned this Dec 23, 2023
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7e4a13) 100.00% compared to head (4f44cbc) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #483   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6        11    +5     
  Lines         2691      2593   -98     
=========================================
- Hits          2691      2593   -98     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CoMPaTech
Copy link
Member Author

Adding quality label as per second half of the commits regarding the SonarCloud smells

@CoMPaTech
Copy link
Member Author

Not sure why the pragma disable (complexity) won't apply (search for disable and restore with S3776). As for the final one on one function always returning true, that does raise an eyebrow.

@CoMPaTech CoMPaTech marked this pull request as ready for review December 23, 2023 14:47
@CoMPaTech CoMPaTech requested a review from a team as a code owner December 23, 2023 14:47
Copy link

sonarcloud bot commented Dec 24, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good!

@CoMPaTech
Copy link
Member Author

Anything else we need to do here, or merge it and see what #485 can bring to the table?

@CoMPaTech
Copy link
Member Author

(and apologies for not correctly saving the transfer of combined :) )

@bouwew
Copy link
Contributor

bouwew commented Dec 24, 2023

No, all looks good now, please merge.

@CoMPaTech CoMPaTech merged commit 6c55c79 into main Dec 24, 2023
16 checks passed
@CoMPaTech CoMPaTech deleted the modular_testing branch December 24, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants