-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split testing - initial split #483
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 11 +5
Lines 2691 2593 -98
=========================================
- Hits 2691 2593 -98 ☔ View full report in Codecov by Sentry. |
231d9e9
to
47d42d1
Compare
Adding quality label as per second half of the commits regarding the SonarCloud smells |
Not sure why the pragma disable (complexity) won't apply (search for |
8c3ed65
to
b21fb65
Compare
e2779cd
to
dea3793
Compare
dea3793
to
2eb0703
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good!
Anything else we need to do here, or merge it and see what #485 can bring to the table? |
(and apologies for not correctly saving the transfer of combined :) ) |
No, all looks good now, please merge. |
Split testing into separate files (improving maintenance & less lengthy monolith file) als dropping 'smile' as that's default for this repo