Enhancement based on #425 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2640 2646 +6
=========================================
+ Hits 2640 2646 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CoMPaTech
approved these changes
Jul 5, 2023
bouwew
force-pushed
the
fix-#425
branch
3 times, most recently
from
11e5be3
to
f530023
Compare
bouwew
added
enhancement
CoMPaTech
reviewed
Jul 7, 2023
plugwise/__init__.py
Outdated
| @@ -685,6 +685,11 @@ async def set_temperature(self, loc_id: str, items: dict[str, float]) -> None: | |||
| if "setpoint_high" in items: | |||
| tmp_setpoint_high = items["setpoint_high"] | |||
| tmp_setpoint_low = items["setpoint_low"] | |||
| else: | |||
There was a problem hiding this comment.
Suggest to rewrite as to raise if not "setpoint_high" in items:
tests/test_smile.py
Outdated
| @@ -486,11 +486,11 @@ async def tinker_switch( | |||
| return tinker_switch_passed | |||
|
|
|||
| @pytest.mark.asyncio | |||
| async def tinker_thermostat_temp(self, smile, loc_id, unhappy=False): | |||
| async def tinker_thermostat_temp(self, smile, loc_id, special=True, unhappy=False): | |||
There was a problem hiding this comment.
Suggest to rename to cooling_special or something likewise (as it is now non-descriptive how/why - or just add why special is there in the description line?
There was a problem hiding this comment.
Changed to block_cooling and revert the default value to False.
CoMPaTech
approved these changes
Jul 7, 2023
CoMPaTech
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final scope: no fix needed for plugwise/plugwise-beta#425, a user-error causes the error shown in the HA LOG.
Changes: