Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve guarding #164

Merged
merged 5 commits into from
Mar 15, 2022
Merged

Improve guarding #164

merged 5 commits into from
Mar 15, 2022

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Mar 15, 2022

@bouwew bouwew requested a review from CoMPaTech March 15, 2022 06:54
@bouwew bouwew marked this pull request as draft March 15, 2022 06:55
@bouwew
Copy link
Contributor Author

bouwew commented Mar 15, 2022

Indeed, this solves plugwise/plugwise-beta#250

@bouwew bouwew marked this pull request as ready for review March 15, 2022 16:52
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #164 (bc34f67) into main (08e965b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2054      2076   +22     
=========================================
+ Hits          2054      2076   +22     
Impacted Files Coverage Δ
plugwise/__init__.py 100.00% <100.00%> (ø)
plugwise/helper.py 100.00% <100.00%> (ø)
tests/test_smile.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08e965b...bc34f67. Read the comment docs.

@bouwew bouwew merged commit 0377e40 into main Mar 15, 2022
@bouwew bouwew deleted the anna_bug_heating_state branch March 15, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants