Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rule for path parameters #9

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

Ko1103
Copy link
Contributor

@Ko1103 Ko1103 commented Aug 14, 2023

Path parameterのチェックルールを追加

  • requiredの設定があるか
  • requiredがtrueになっているか

これはopenapi-generatorだとerrorになるようになっているので、合わせる形にした。

Copy link

@seiya0429 seiya0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seiya0429 seiya0429 marked this pull request as ready for review August 14, 2023 01:17
@Ko1103 Ko1103 merged commit 3703f0b into main Aug 14, 2023
1 check passed
@Ko1103 Ko1103 deleted the feature/add-rule-for-path-param branch August 14, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants