Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Inconsistency in form import feature #722

Closed
btry opened this issue Sep 15, 2017 · 1 comment
Closed

Code Inconsistency in form import feature #722

btry opened this issue Sep 15, 2017 · 1 comment
Assignees
@btry
Labels
bug

Comments

@btry
Copy link
Collaborator

btry commented Sep 15, 2017 •
edited
Loading

There is something wrong in this block of code (method import())

https://github.com/pluginsGLPI/formcreator/blob/develop/inc/form_profile.class.php#L100

$form is not defined in the method.

Also the returned variable $validator_id is not defiined too.
@btry btry added the bug label Sep 15, 2017
@btry
Copy link
Collaborator Author

btry commented Jul 4, 2018

Import of restriction by profile probably never worked

btry added a commit to btry/formcreator that referenced this issue Jul 4, 2018
@btry
fix(form): import restrictions by profile was broken
393acaf 
fix pluginsGLPI#722
Signed-off-by: btry <tbugier@teclib.com>
@btry btry self-assigned this Jul 4, 2018
btry added a commit to btry/formcreator that referenced this issue Jul 10, 2018
@btry
fix(form): import restrictions by profile was broken
3c7ecd0 
fix pluginsGLPI#722
Signed-off-by: btry <tbugier@teclib.com>
@btry btry closed this as completed in 34ae3bf Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@btry btry

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@btry