fix(ldapfield): PHP warning when editing the question

fix #2116 Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Feb 18, 2021 · db452c7 · db452c7
1 parent 9fd8c1a
commit db452c7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/inc/field/ldapselectfield.class.php b/inc/field/ldapselectfield.class.php
@@ -103,7 +103,7 @@ public function getDesignSpecializationField(): array {
       $additions .= '<td colspan="2">&nbsp;</td>';
       $additions .= '</tr>';
 
-      $common = parent::getDesignSpecializationField();
+      $common = PluginFormcreatorAbstractField::getDesignSpecializationField();
       $additions .= $common['additions'];
 
       return [

diff --git a/tests/4-functional/Glpi/Plugin/Formcreator/Field/LdapSelectField.php b/tests/4-functional/Glpi/Plugin/Formcreator/Field/LdapSelectField.php
@@ -69,8 +69,6 @@ public function testCreateForm() {
       $this->client->waitForVisibility('form[data-itemtype="PluginFormcreatorQuestion"] select[name="show_empty"]');
       $this->client->waitForVisibility('form[data-itemtype="PluginFormcreatorQuestion"] input[name="ldap_filter"]');
       $this->client->waitForVisibility('form[data-itemtype="PluginFormcreatorQuestion"] select[name="ldap_attribute"]');
-      $this->client->waitForVisibility('form[data-itemtype="PluginFormcreatorQuestion"] input[name="default_values"]');
-      $this->client->waitForVisibility('form[data-itemtype="PluginFormcreatorQuestion"] textarea[name="values"]');
 
       $authLdap = new \AuthLDAP();
       $ldaps = $authLdap->find([], [], 1);