refactor(condition): cleanup JS, use method to get type

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Aug 7, 2020 · 57a9831 · 57a9831
1 parent 4491e7a
commit 57a9831
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/inc/condition.class.php b/inc/condition.class.php
@@ -213,7 +213,7 @@ public function getConditionsFromItem(CommonDBTM $item) {
          'SELECT' => ['id'],
          'FROM'   => self::getTable(),
          'WHERE'  => [
-            'itemtype' => get_class($item),
+            'itemtype' => $item->getType(),
             'items_id' => $item->getID()
          ],
          'ORDER'  => 'order ASC'
@@ -243,7 +243,7 @@ public function showConditionsForItem(CommonDBTM $item) {
          $this->getEnumShowRule(),
          [
             'value'        => $item->fields['show_rule'],
-            'on_change'    => 'plugin_formcreator_toggleCondition(this, "' . $item->getType() . '");',
+            'on_change'    => 'plugin_formcreator_toggleCondition(this);',
             'rand'         => $rand,
          ]
       );