Not imported template (#3449)

fix(targetticket,targetchange,targetproblem): not imported template
pluginsGLPI · Feb 29, 2024 · 29ed099 · 29ed099
1 parent cb9ce0f
commit 29ed099
Show file tree

Hide file tree

Showing 6 changed files with 47 additions and 0 deletions.
diff --git a/inc/abstracttarget.class.php b/inc/abstracttarget.class.php
@@ -79,6 +79,8 @@ abstract public static function getTargetItemtypeName(): string;
     */
    abstract protected function getTaggableFields();
 
+   abstract protected function getTemplateItemtypeName();
+
    const DESTINATION_ENTITY_CURRENT = 1;
    const DESTINATION_ENTITY_REQUESTER = 2;
    const DESTINATION_ENTITY_REQUESTER_DYN_FIRST = 3;
@@ -561,4 +563,18 @@ public function prepareInputForClone($input) {
       unset($input['uuid']);
       return $input;
    }
+
+   protected static function getTemplateByName(string $name): int {
+      $targetTemplateType = (new static())->getTemplateItemtypeName();
+      $targetTemplate = new $targetTemplateType();
+      $targetTemplate->getFromDBByCrit([
+         'name' => $name,
+      ]);
+
+      if ($targetTemplate->isNewItem()) {
+         return 0;
+      }
+
+      return $targetTemplate->getID();
+   }
 }
diff --git a/inc/targetchange.class.php b/inc/targetchange.class.php
@@ -288,6 +288,16 @@ public static function import(PluginFormcreatorLinker $linker, array $input = []
          $input[$fieldSetting['field']] = $question->getID();
       }
 
+      // Find template by name
+      $input['changetemplates_id'] = 0;
+      if (is_string($input['_changetemplate']) && strlen($input['_changetemplate']) > 0) {
+         $input['changetemplates_id'] = self::getTemplateByName($input['_changetemplate']);
+         if ($input['changetemplates_id'] === 0) {
+            $typeName = strtolower(self::getTypeName());
+            throw new ImportFailureException(sprintf(__('Failed to add or update the %1$s %2$s: It uses a non existent template', 'formceator'), $typeName, $input['name']));
+         }
+      }
+
       // Add or update
       $originalId = $input[$idKey];
       $item->skipChecks = true;

diff --git a/inc/targetproblem.class.php b/inc/targetproblem.class.php
@@ -525,6 +525,15 @@ public static function import(PluginFormcreatorLinker $linker, array $input = []
          $input[$fieldSetting['field']] = $question->getID();
       }
 
+      // Find template by name
+      $input['problemtemplates_id'] = 0;
+      if (is_string($input['_problemtemplate']) && strlen($input['_problemtemplate']) > 0) {
+         $input['problemtemplates_id'] = self::getTemplateByName($input['_problemtemplate']);
+         if ($input['problemtemplates_id'] === 0) {
+            $typeName = strtolower(self::getTypeName());
+            throw new ImportFailureException(sprintf(__('Failed to add or update the %1$s %2$s: It uses a non existent template', 'formceator'), $typeName, $input['name']));
+         }
+      }
       // Add or update
       $originalId = $input[$idKey];
       $item->skipChecks = true;

diff --git a/inc/targetticket.class.php b/inc/targetticket.class.php
@@ -1404,6 +1404,16 @@ public static function import(PluginFormcreatorLinker $linker, array $input = []
          $input[$fieldSetting['field']] = $question->getID();
       }
 
+      // Find template by name
+      $input['tickettemplates_id'] = 0;
+      if (is_string($input['_tickettemplate']) && strlen($input['_tickettemplate']) > 0) {
+         $input['tickettemplates_id'] = self::getTemplateByName($input['_tickettemplate'] ?? '');
+         if ($input['tickettemplates_id'] === 0) {
+            $typeName = strtolower(self::getTypeName());
+            throw new ImportFailureException(sprintf(__('Failed to add or update the %1$s %2$s: It uses a non existent template', 'formceator'), $typeName, $input['name']));
+         }
+      }
+
       // Add or update
       $originalId = $input[$idKey];
       $item->skipChecks = true;

diff --git a/tests/3-unit/PluginFormcreatorTargetChange.php b/tests/3-unit/PluginFormcreatorTargetChange.php
@@ -505,6 +505,7 @@ public function testImport() {
          'tag_specifics' => '',
          'category_rule' => \PluginFormcreatorTargetChange::CATEGORY_RULE_NONE,
          'category_question' => '0',
+         '_changetemplate' => '',
          'uuid' => $uuid,
       ];
 

diff --git a/tests/3-unit/PluginFormcreatorTargetTicket.php b/tests/3-unit/PluginFormcreatorTargetTicket.php
@@ -782,6 +782,7 @@ public function testImport() {
          'source_question' => 0,
          'type_rule' => 1,
          'type_question' => 0,
+         '_tickettemplate' => '',
          'uuid' => $uuid,
       ];