Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phpstan level 5 #911

Merged
merged 9 commits into from
Feb 7, 2025
Merged

Phpstan level 5 #911

merged 9 commits into from
Feb 7, 2025

Conversation

Lainow
Copy link
Contributor

@Lainow Lainow commented Jan 22, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

@Rom1-B Rom1-B self-requested a review January 22, 2025 10:29
@Lainow Lainow mentioned this pull request Jan 22, 2025
Merged
4 tasks
Rom1-B
Rom1-B requested changes Feb 4, 2025
View reviewed changes
hook.php Outdated Show resolved Hide resolved
inc/container.class.php Outdated Show resolved Hide resolved
inc/inventory.class.php Outdated Show resolved Hide resolved
inc/toolbox.class.php Outdated Show resolved Hide resolved
@Lainow @Rom1-B
Update inc/container.class.php
3161ea2 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@Lainow Lainow requested a review from Rom1-B February 6, 2025 10:31
Rom1-B
Rom1-B requested changes Feb 6, 2025
View reviewed changes
inc/inventory.class.php Outdated Show resolved Hide resolved
hook.php Outdated Show resolved Hide resolved
@Lainow Lainow self-assigned this Feb 6, 2025
@Lainow Lainow requested a review from Rom1-B February 6, 2025 13:46
Lainow and others added 2 commits February 6, 2025 14:47
@Lainow @Rom1-B
Update inc/inventory.class.php
3597ceb 
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@Lainow
Fix phpstan error
3e73280
@Rom1-B Rom1-B requested a review from stonebuzz February 6, 2025 14:46
@Rom1-B Rom1-B merged commit 39b73cf into pluginsGLPI:main Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonebuzz stonebuzz stonebuzz approved these changes

@Rom1-B Rom1-B Rom1-B approved these changes

Assignees

@Lainow Lainow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lainow @stonebuzz @Rom1-B