Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use of Session::haveRight('user', 'r') #296

Closed
ctresvaux opened this issue Dec 10, 2018 · 2 comments
Closed

use of Session::haveRight('user', 'r') #296

ctresvaux opened this issue Dec 10, 2018 · 2 comments
Assignees
@cedric-anne
Labels
bug
Milestone
1.9.1

Comments

@ctresvaux
Copy link

ctresvaux commented Dec 10, 2018 •
edited
Loading

Hi,
I use your plugin in my glpi project.
I noticed thant there is a call to the core function Session::haveRight('user', 'r') with deprecated syntax in the file inc/field.class.php
It causes notices in php-errors log file.

I think the right syntax is now Session::haveRight('user', READ)

Regards
Christian
cedric-anne added a commit to cedric-anne/glpi-plugin-fields that referenced this issue Dec 10, 2018
@cedric-anne
Fix user rights check; fixes pluginsGLPI#296
af3f376
@cedric-anne
Copy link
Contributor

Hi,

Thanks for feedback.
I made a PR with your fix, which seems right. Could you tell us if it fixes your problem ?

#297

Regards

@cedric-anne cedric-anne self-assigned this Dec 10, 2018
@cedric-anne cedric-anne added this to the 1.9.1 milestone Dec 10, 2018
cedric-anne added a commit that referenced this issue Feb 11, 2019
@cedric-anne
Fix user rights check; fixes #296
8877cf0
@cedric-anne
Copy link
Contributor

Fixed by 8877cf0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cedric-anne cedric-anne

Labels
bug
Projects
None yet
Milestone
1.9.1
Development

No branches or pull requests
2 participants
@ctresvaux @cedric-anne