Remove add_reasons_to_defaults() from general initialization
#627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this re-introduces #508.
Query Monitor screenshot: 
Translation-wise it looks fine though. |
|
@swissspidy great catch! I first wondered on how/where the Oh boy! Time to get this old code gone and My new commit should fix it. It now loads the "reasons" in an |
swissspidy
approved these changes
Oct 29, 2024
The `add_reasons_to_defaults()` adds the translatable strings to the `$default`. Those `reasons` are only needed inside the `send_mail_notification()` method, which also calls the `add_reasons_to_defaults()` function. Therefore, the function call can be removed from the general `init()` function.
…st_in_time()` This function is calling the `load_plugin_textdomain()`, which eventually become deprecated soon. Since this plugin is also using the "Text Domain" plugin header, it is not necessary to call this function at all. By removing this function, the `_load_textdomain_just_in_time()` function will be used, when the first string needs to be translated.
Since we don't explicitly load the translation files anymore this will make sure that the necessary function is there.
2ndkauboy
force-pushed
the
fix/625-load_textdomain-just-in-time
branch
from
be234e8 to
f083959
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
add_reasons_to_defaults()adds the translatable strings to the$default. Thosereasonsare only needed inside thesend_mail_notification()method, which also calls theadd_reasons_to_defaults()function. Therefore, the function call can be removed from the generalinit()function.Fixes #625