-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added argument 0 to method pluginmode in order to exit from pluginmode #1858
Conversation
if(pluginModeFloatArgument) | ||
patches[0]->openInPluginMode = true; | ||
else | ||
patches[0]->openInPluginMode = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I don't know if this line (1533) is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is? How else you it quit pluginmode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean I don't know when this code is executed, as in the if (!editors.isEmpty())
line before (l. 1520), the condition is always true, from what I understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could send a [pluginmode 0(
message.
Might make sense if a user does [pluginmode $1(
and sends 0
or 1
in?
This doesn't seem to work at all. When I send |
Very strange. Did you rebuild from main branch ? |
Oh damn, this was merged to @timothyschoen I think it would make sense to make |
Sorry, but I couldn't sync my fork with the current develop branch, as there were errors with pd-else sub-repository. So I pulled from the main branch. I will try to resolve this for next time :-) |
…d [;pdpluginmode( in develop branch
sent to pd receiver, the message [pluginmode 0( will exit from pluginmode.
As before, other arguments will activate pluginmode :
e.g. :