Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added argument 0 to method pluginmode in order to exit from pluginmode #1858

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

jyg
Copy link
Contributor

@jyg jyg commented Sep 22, 2024

sent to pd receiver, the message [pluginmode 0( will exit from pluginmode.
As before, other arguments will activate pluginmode :
e.g. :

  • [pluginmode(
  • [pluginmode 1(
  • [pluginmode -theme_name-(

if(pluginModeFloatArgument)
patches[0]->openInPluginMode = true;
else
patches[0]->openInPluginMode = false;
Copy link
Contributor Author

@jyg jyg Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I don't know if this line (1533) is necessary

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is? How else you it quit pluginmode?

Copy link
Contributor Author

@jyg jyg Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean I don't know when this code is executed, as in the if (!editors.isEmpty()) line before (l. 1520), the condition is always true, from what I understand.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could send a [pluginmode 0( message.
Might make sense if a user does [pluginmode $1( and sends 0 or 1 in?

@timothyschoen timothyschoen merged commit c40830f into plugdata-team:main Sep 25, 2024
@dromer
Copy link
Contributor

dromer commented Sep 25, 2024

This doesn't seem to work at all.

When I send [pluginmode 0( to [s pd] it goes to plugin-mode and sending it again does not exit.

@jyg
Copy link
Contributor Author

jyg commented Sep 25, 2024

This doesn't seem to work at all.

When I send [pluginmode 0( to [s pd] it goes to plugin-mode and sending it again does not exit.

Very strange. Did you rebuild from main branch ?

@dromer
Copy link
Contributor

dromer commented Sep 25, 2024

Oh damn, this was merged to main and not develop -_-

@timothyschoen I think it would make sense to make develop the default branch as this happens way too often ..

@jyg
Copy link
Contributor Author

jyg commented Sep 25, 2024

Oh damn, this was merged to main and not develop -_-

Sorry, but I couldn't sync my fork with the current develop branch, as there were errors with pd-else sub-repository. So I pulled from the main branch. I will try to resolve this for next time :-)

jyg added a commit to jyg/plugdata that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants