More numberbox improvements

plugdata-team · Feb 14, 2025 · 5e06b19 · 5e06b19
1 parent ab48784
commit 5e06b19
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/Source/Components/DraggableNumber.h b/Source/Components/DraggableNumber.h
@@ -124,19 +124,17 @@ class DraggableNumber : public Component, public TextEditor::Listener
     {
         minimumHorizontalScale = newScale;
     }
-
-    void setJustificationType(Justification just)
-    {
-        // TODO: implement this!
-    }
-
+
     void setText(String const& newText, NotificationType notification)
     {
+        hideEditor(false);
+
         currentValue = newText;
         repaint();
 
-        //onTextChange();
-        // TODO: send notification!
+        if(notification == sendNotification) {
+            onTextChange();
+        }
     }
 
     TextEditor* getCurrentTextEditor()
@@ -275,6 +273,7 @@ class DraggableNumber : public Component, public TextEditor::Listener
             std::swap (outgoingEditor, editor);
 
             if(!discardCurrentEditorContents) {
+                decimalDrag = 0;
                 updateFromTextEditorContents (*outgoingEditor);
             }
 
@@ -342,9 +341,8 @@ class DraggableNumber : public Component, public TextEditor::Listener
 
         if (!approximatelyEqual(lastValue, newValue) && notification != dontSendNotification) {
             onValueChange(newValue);
+            lastValue = newValue;
         }
-
-        lastValue = newValue;
     }
 
     double getValue() const

diff --git a/Source/Objects/ListObject.h b/Source/Objects/ListObject.h
@@ -23,8 +23,6 @@ class ListObject final : public ObjectBase {
     {
         listLabel.setBounds(2, 0, getWidth() - 2, getHeight() - 1);
         listLabel.setMinimumHorizontalScale(1.f);
-        listLabel.setJustificationType(Justification::centredLeft);
-        // listLabel.setBorderSize(BorderSize<int>(2, 6, 2, 2));
 
         addAndMakeVisible(listLabel);
 

diff --git a/Source/Sidebar/AutomationPanel.h b/Source/Sidebar/AutomationPanel.h
@@ -231,7 +231,6 @@ class AutomationItem final : public ObjectDragAndDrop
         };
 
         valueLabel.setMinimumHorizontalScale(1.0f);
-        valueLabel.setJustificationType(Justification::centred);
 
         nameLabel.setMinimumHorizontalScale(1.0f);
         nameLabel.setJustificationType(Justification::centred);