-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord Provider #13
Discord Provider #13
Conversation
I'd rather the import path not be renamed from Other than that, there's just some minor whitespace/formatting issues. |
This reverts commit cf9fac0.
Fair enough, reverting that commit 👍 I didn't mean to add it in this pull request since it wasn't part of the Discord provider. |
gofmt is indeed picky
Thanks! (I pushed up one last gofmt tweak ... the trick is |
I apologize for not speaking Go too natively, my last Go project was a year or so ago 😅 thank you for your help |
p.ValidateURL = p.ProfileURL | ||
} | ||
if p.Scope == "" { | ||
p.Scope = "identify email connections" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like "connections" is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and some other little refinements could be in a follow-up pull request if someone cares enough :)
(e.g. removing parts of DiscordUserInfo which are unused, maybe checking Verified property ...)
It isn't needed right now, but I'd like to extend from the user and email that are by default provided to the proxied host at some point: similar to the way that |
Release 3.0.0
Implemented per https://discordapp.com/developers/docs/topics/oauth2.