Hotfix: clean up visible false scatter trace #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as of PR #802, scatter traces are no longer purged in the per-subplot cartesian plot step - to maintain consistency between transitions. - While the scatter plot module can remove individual 'visible: false' traces, when all scatter traces are restyled to 'visible: false' the scatter plot module is currently not called!
| } | ||
| } | ||
| } | ||
| }; |
|
Agreed on changing the 💃 from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting all scatter traces to
visible: falseon a given graph at once (e.g. byPlotly.restyle(gd, 'visible', false);is currently broken inmasterandv1.17.0ever since commit 57892ed of PR #802. By broken, I meant thevisible: falsetraces remain visible on the graph after the update.As of 57892ed, scatter traces aren't purged in the cartesian subplot plot step (see here), meaning that the
Scattertrace module takes the responsibility of cleaning upvisible: falsetraces - which works fine except when all scatter traces are simultaneously gone. In this case,fullLayout._modulesdoes not contain theScattermodule here andScatter.plotis not called here.I'm starting to think that we are not correctly handling
visible: falsestarting from the tracesupplyDefaults. Changing that will be a bigger project that I'd call too ambitious for a patch release. So, I propose this fix that uses theplots.cleanPlotstep.@rreusser