Break up annotations and shapes components #833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... into digestible files.
This break up will make it easier to share code between
annotations
,shapes
and other layout components.Moreover, in this PR
Annotations.drawAll
andShapes.drawAll
were replaced bydraw
consistent with other layout componentsPlotly.relayout
calls the one-item draw method which used to be calleddraw
, but now renamedrawOne
. This pattern should will be clean up in the future.helpers.js
)relayout
tests for annotations (we didn't have any yet 😉 )