Drop support for deprecated error bar opacity attribute (use alpha channel of error bar color attribute instead)
#7216
Conversation
…rror bar 'color' attribute instead)
| @@ -72,16 +72,14 @@ | |||
| "value": 0.1, | |||
| "color": "#85144B", | |||
| "thickness": 1.5, | |||
| "width": 3, | |||
| "opacity": 1 | |||
There was a problem hiding this comment.
just for my own learning, what happened to "opacity"?
There was a problem hiding this comment.
opacity can also be specified by using the alpha channel of the color attribute, which defaults to full-opacity, so the same image result can be achieved without explicitly setting the opacity.
I guess for the purposes of this test it might make sense to include it explicitly though.
There was a problem hiding this comment.
very happy to use color instead (fewer parameters is better) - was just wondering how we were now handling it - thanks
There was a problem hiding this comment.
I don't know why we chose to deprecate opacity here though and not elsewhere, maybe @archmoj has an idea
There was a problem hiding this comment.
In some places - particularly where multiple colors or multiple objects are involved - there are many different effects you can achieve depending on exactly where you set the opacity
Here though I guess there's nothing you can't achieve just with the opacity of the color.
There was a problem hiding this comment.
That makes perfect sense -- thanks @alexcjohnson .
test/plot-schema.json
Outdated
| @@ -17391,7 +17384,7 @@ | |||
| "valType": "string" | |||
| }, | |||
| "color": { | |||
| "description": "Sets the stoke color of the error bars.", | |||
| "description": "Sets the stroke color of the error bars.", | |||
|
FYI @archmoj I updated the |
Closes #7197
opacityattribute (use alpha channel of error barcolorattribute instead)