-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop deprecated pointcloud
and heatmapgl
traces and gl2d
subplots
#7213
Conversation
@archmoj Are Is there a replacement for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @archmoj , I don't see any red flags as long as tests are passing
@emilykl No they are not direct drop-in replacements. |
@alexcjohnson Would you accept these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my understanding it’s actually heatmap
that replaces heatmapgl
, ie just “downgrading” to the SVG version gives you the same or better performance with many more features. pointcloud
is different, scattergl
is not a drop-in replacement, but it solves the same use cases and many more.
this is great, I highly support these changes 💃
Closes #7176 and closes #7175.
Users could use
scattergl
andheatmap
traces instead to draw similar graphs.@plotly/plotly_js