Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated pointcloud and heatmapgl traces and gl2d subplots #7213

Merged
merged 23 commits into from
Oct 8, 2024

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 7, 2024

Closes #7176 and closes #7175.
Users could use scattergl and heatmap traces instead to draw similar graphs.
@plotly/plotly_js

@emilykl
Copy link
Contributor

emilykl commented Oct 7, 2024

@archmoj Are scattergl and image direct drop-in replacements for pointcloud and heatmapgl? Or are some of the props different?

Is there a replacement for gl2d subplots?

Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @archmoj , I don't see any red flags as long as tests are passing

@gvwilson gvwilson added feature something new P1 needed for current cycle labels Oct 8, 2024
@archmoj
Copy link
Contributor Author

archmoj commented Oct 8, 2024

@archmoj Are scattergl and image direct drop-in replacements for pointcloud and heatmapgl? Or are some of the props different?

Is there a replacement for gl2d subplots?

@emilykl No they are not direct drop-in replacements.
gl2d subplots are only only used for these these two traces and other 2-D WebGL-based traces e.g. scattergl, splom and parcoords do not use it.

@archmoj
Copy link
Contributor Author

archmoj commented Oct 8, 2024

@alexcjohnson Would you accept these changes?

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my understanding it’s actually heatmap that replaces heatmapgl, ie just “downgrading” to the SVG version gives you the same or better performance with many more features. pointcloud is different, scattergl is not a drop-in replacement, but it solves the same use cases and many more.

this is great, I highly support these changes 💃

@archmoj archmoj merged commit 2c51844 into master Oct 8, 2024
1 check passed
@archmoj archmoj deleted the drop-gl2d branch October 8, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop pointcloud for Plotly.js v3 Drop heatmapgl for Plotly.js v3
4 participants