Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing cursor for ternary plot #7057

Merged
merged 9 commits into from
Jul 22, 2024
Merged

Fix missing cursor for ternary plot #7057

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8835add
fix missing cursor for ternary plot
Lexachoc Jul 20, 2024
9ec32e8
Fix missing cursor for ternary plot
Lexachoc Jul 20, 2024
06b7148
Create 7057_fix.md
Lexachoc Jul 20, 2024
b203a25
Update src/plots/ternary/ternary.js
Lexachoc Jul 22, 2024
e8de4c9
Update draftlogs/7057_fix.md
Lexachoc Jul 22, 2024
a48213c
Update index.js
Lexachoc Jul 22, 2024
99de97e
Update index.js
Lexachoc Jul 22, 2024
99ccd12
Update ternary.js
Lexachoc Jul 22, 2024
7e9abcf
fix with lint
Lexachoc Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions draftlogs/7057_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fix missing cursor for Ternary Plot[[#7057](https://github.com/plotly/plotly.js/pull/7057)],
with thanks to @Lexachoc for the contribution!
8 changes: 8 additions & 0 deletions src/plots/ternary/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,11 @@ exports.clean = function(newFullData, newFullLayout, oldFullData, oldFullLayout)
}
}
};

exports.updateFx = function(gd) {
var fullLayout = gd._fullLayout;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run lint -- --fix and commit the changes.

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I hope I'm doing it correctly.

fullLayout._ternarylayer
.selectAll('g.toplevel')
.style('cursor', fullLayout.dragmode === 'pan' ? 'move' : 'crosshair');
};
7 changes: 7 additions & 0 deletions src/plots/ternary/ternary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ function Ternary(options, fullLayout) {
this.graphDiv = options.graphDiv;
this.init(fullLayout);
this.makeFramework(fullLayout);
this.updateFx(fullLayout);

// unfortunately, we have to keep track of some axis tick settings
// as ternary subplots do not implement the 'ticks' editType
Expand Down Expand Up @@ -97,6 +98,12 @@ proto.makeFramework = function(fullLayout) {
Drawing.setClipUrl(_this.layers.grids, clipId, gd);
};

proto.updateFx = function(fullLayout) {
fullLayout._ternarylayer
.selectAll('g.toplevel')
.style('cursor', fullLayout.dragmode === 'pan' ? 'move' : 'crosshair');
};

proto.updateLayers = function(ternaryLayout) {
var _this = this;
var layers = _this.layers;
Expand Down