Fix for #6614 #6615
Merged
Fix for #6614 #6615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. |
archmoj
added
bug
|
Nicely done. 💃 [ ] 💃 |
|
@archmoj Looks like one test still fails. I don't expect this to be connected to my change though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written in the issue, the hover fails, if the only markers currently visible are hoverinfo: "none".
This fix returns an empty array instead of undefined in
createHoverTextif no points are currently shown.Prev:
if(groupedHoverData.length === 0) return;LinkNow:
if(groupedHoverData.length === 0) return [];So that
var hoverLabel = hoverText.hoverLabels;does not fail.A test for regression is also added. It fails without the given change.