Add editSelection option to config

[archmoj]

So that modifying selections after creation could be disabled.
@nicolaskruchten
@plotly/plotly_js

[alexcjohnson]

💃 LGTM, pending @nicolaskruchten verifying that this fixes the issue with FigureWidget

[nicolaskruchten]

Yes, I'm able to hack the widget a bit to make this work. However, when I set this option to true, the shift-selection behaviour is pretty weird: if I make an initial selection it's fine, then shift-click-drag to make a new one doesn't give me the incremental box as I drag, and when I mouse-up, the box is pinned to my mouse and doesn't 'take' until I click.

[archmoj]

Yes, I'm able to hack the widget a bit to make this work. However, when I set this option to true, the shift-selection behaviour is pretty weird: if I make an initial selection it's fine, then shift-click-drag to make a new one doesn't give me the incremental box as I drag, and when I mouse-up, the box is pinned to my mouse and doesn't 'take' until I click.

@alexcjohnson I think we are happy with this current GUI default. No?

[nicolaskruchten]

This clearly feels like a bug to me... when the circle appears around my cursor is when my mouse button is down.

Screen.Recording.2022-08-09.at.10.06.23.mov

[archmoj]

This clearly feels like a bug to me... when the circle appears around my cursor is when my mouse button is down.

Screen.Recording.2022-08-09.at.10.06.23.mov

That doesn't happen at plotly.js level. Right?
Also this PR is related to providing the false option. I mean the true option behaves the same before and after this PR.

[nicolaskruchten]

This does happen at the Plotly.js level... And this behaviour only appears in false mode, so it's a bug with this PR basically, right?

[nicolaskruchten]

This does happen at the Plotly.js level

Sorry, if you meant "does this happen outside of Jupyter in a CodePen?" the answer appears to be no.

[nicolaskruchten]

And this behaviour only appears in false mode

Well, apparently this isn't true either 🤯 ... Even without this flag set, I get this odd behaviour in Jupyter. OK then, please ignore the noise, we can merge this PR.