-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nl translation #6261
Update nl translation #6261
Conversation
I've also added the draft log file, though I'm not sure if it was required for a translation change. If anything else is needed, let me know! |
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
Co-authored-by: rriksma-fouriq <51152705+rriksma-fouriq@users.noreply.github.com>
Co-authored-by: rriksma-fouriq <51152705+rriksma-fouriq@users.noreply.github.com>
Please add spaces here so that the test pass & and we could possibly include it in the next plotly.js minor soon. $ eslint .
|
💃 |
Sorry that I didn't apply thee added spaces, I was on holiday🙈. Thanks for changing, glad to have helped! |
Thanks for your interest in plotly.js!
Translations:
hover
would translate to a very verbose wayFeatures, Bug fixes, and others:
Before opening a pull request, developer should:
1. make sure they are not on the
master
branch of their fork as usingmaster
for a pull request would make it difficult to fetchupstream
changes.2. fetch latest changes from
upstream/master
into your fork i.e.origin/master
then pullorigin/master
from you localmaster
.3. then
git rebase master
their local dev branch off the latestmaster
which should be sync withupstream/master
at this time.4. make sure to not
git add
thedist/
folder (thedist/
is updated only on version bumps).5. make sure to commit changes to the
package-lock.json
file (if any new dependency required).6. provide a title and write an overview of what the PR attempts to do with a link to the issue they are trying to address.
7. select the Allow edits from maintainers option (see this article for more details).
After opening a pull request, developer:
- should create a new small markdown log file using the PR number e.g.
1010_fix.md
or1010_add.md
insidedraftlogs
folder as described in this README, commit it and push.should not force push (i.e.
git push -f
) to remote branches associated with opened pull requests. Force pushes make it hard for maintainers to keep track of updates. Therefore, if required, please fetchupstream/master
and "merge" with master instead of "rebase".