Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legend.groupclick options to toggle single item within a group #5906

Merged
merged 8 commits into from
Aug 26, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 25, 2021

Supersedes #5849 | cc: @brussee

@plotly/plotly_js

@archmoj archmoj added feature something new community community contribution labels Aug 25, 2021
@archmoj archmoj added this to the v2.4.0 milestone Aug 25, 2021
@archmoj archmoj requested a review from alexcjohnson August 25, 2021 18:57
@brussee
Copy link
Contributor

brussee commented Aug 26, 2021

Thanks for finishing up my feature & pull request!

Did you manage to test for the AND item click !== false here? #5849 (comment)

And is the case of a "toggle others" already defined (on double click) in the new case of "toggle item"?

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 164d760 into master Aug 26, 2021
@archmoj archmoj deleted the pull-5849 branch August 26, 2021 16:43
@archmoj
Copy link
Contributor Author

archmoj commented Aug 26, 2021

@brussee thanks very much for your contribution 🥇
Please feel free to open PRs to further improve or test the new features.

@brussee
Copy link
Contributor

brussee commented Aug 26, 2021

For reference: Fixes #3135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants