Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes auto-margin step dependent on axis label span #312

Closed
wants to merge 1 commit into from
Closed

Makes auto-margin step dependent on axis label span #312

wants to merge 1 commit into from

Conversation

WA9ACE
Copy link

@WA9ACE WA9ACE commented Mar 3, 2016

This should resolve issue #296 and allow for displaying longer labels without them getting cutoff.

@WA9ACE
Copy link
Author

WA9ACE commented Mar 3, 2016

I received this same timeout when running the tests locally. Anyone have an idea of what's wrong?

@mdtusz
Copy link
Contributor

mdtusz commented Mar 3, 2016

If you check the ci build, you'll see there are some image tests failing (e.g. this one). To view the diffs, you can go to the "artifacts" tab, then click down through the directory tree until you get to test_images and test_images_diff directories.

The changes seem to be shifting the plot over to the right, leaving lots of empty space in the left margin - at quick glance, this is probably because of the horizontalShift calculated value.

@mdtusz
Copy link
Contributor

mdtusz commented Apr 7, 2016

@C0deMaver1ck are you still working on this?

@WA9ACE WA9ACE closed this Apr 12, 2016
@hy9be
Copy link
Contributor

hy9be commented Jan 12, 2017

@C0deMaver1ck Just wondering why you closed the PR. Any complicated problems in the logic that you think it is impossible to overcome?

@WA9ACE
Copy link
Author

WA9ACE commented Jan 12, 2017

This just isn't an area of development I have expertise in and didn't/don't have time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants