Unbind VAO in gl-surface3d #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@etpinard not sure what was the tiny shading difference caused by, seems like some internal webgl thing. Not even sure what baselines are correct - before or after, because code after seems "more right". As if shading quality is different, or dithering enabled, or some floats get extra-precision or something alike. The other surface mocks are fine. |
|
This looks right! Thanks for the quick fix 💃 cc @alexcjohnson and anyone else that opened a PR since #2293 |
|
Oh and re #2293 (comment), yes we can remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix gl3d-surface tests #2293 (comment)