Remove erroneous traces in multi-subplot layout containing fill-to scatter traces #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which erroneous traces in multi-violin subplots.
etpinard
commented
Nov 24, 2016
| @@ -0,0 +1,3659 @@ | |||
| { | |||
| "data": [ | |||
There was a problem hiding this comment.
Plotting this mock with the current master gives:
etpinard
commented
Nov 24, 2016
| cdSubplot.indexOf(pcd) === -1) { | ||
| if( | ||
| pcd && | ||
| pcd[0].trace.xaxis + pcd[0].trace.yaxis === subplot && |
There was a problem hiding this comment.
@rreusser does this look right to you?
There was a problem hiding this comment.
Ahhh, I see. cd is all the subplots. Yup, fix looks good to me.
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1196
which were broken since
1.17.0by during the animation push of PR #802In brief, erroneous traces are currently appearing when a cartesian trace in one subplot is followed by a scatter trace with fill set to one of
['tonextx', 'tonexty', 'tonext]- like inplotly.py-manufactured violins as discovered in #1196The fix is pretty straight forward: when adding previous traces to a trace module calcdata array (done to get fills right), we now make sure that the previous traces are on the same subplot as the current traces. This PR also adds a mock 🔒 ing down plotly.py violins.