Set notch width range to (0, 0.5) instead of (0,1)

presumably for better consistency with Matlab
plotly · Jan 30, 2018 · 4ffc52b · 4ffc52b
1 parent e621d0f
commit 4ffc52b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/src/traces/box/attributes.js b/src/traces/box/attributes.js
@@ -96,12 +96,12 @@ module.exports = {
     notchwidth: {
         valType: 'number',
         min: 0,
-        max: 1,
+        max: 0.5,
         dflt: 0.25,
         role: 'style',
         editType: 'calcIfAutorange',
         description: [
-            'Sets the width of the notches inversely proportional to',
+            'Sets the width of the notches relative to',
             'the box\' width.',
             'For example, with 0, the notches are as wide as the box(es).'
         ].join(' ')

diff --git a/src/traces/box/plot.js b/src/traces/box/plot.js
@@ -102,7 +102,7 @@ function plotBoxAndWhiskers(sel, axes, trace, t) {
     var bPosPxOffset = t.bPosPxOffset || 0;
     var whiskerWidth = trace.whiskerwidth || 0;
     var notched = trace.notched || false;
-    var nw = notched ? 1 - trace.notchwidth : 1;
+    var nw = notched ? 1 - 2 * trace.notchwidth : 1;
 
     // to support for one-sided box
     var bdPos0;

diff --git a/test/image/baselines/box_horz_notched.png b/test/image/baselines/box_horz_notched.png
diff --git a/test/image/baselines/box_notched.png b/test/image/baselines/box_notched.png