Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components suite logs #939

Merged
merged 10 commits into from
Sep 27, 2019
Merged

Components suite logs #939

merged 10 commits into from
Sep 27, 2019

Conversation

byronz
Copy link
Contributor

@byronz byronz commented Sep 25, 2019 •
edited
Loading

Start with a description of this PR. Then edit the list below to the items that make sense for your PR scope, and check off the boxes as you go!

Contributor Checklist

  • [x ] I have broken down my PR scope into the following TODO tasks
    • fix
  • I have run the tests locally and they passed. (refer to testing section in contributing)

optionals

  • I have added entry in the CHANGELOG.md

this closes #938

byronz
byronz commented Sep 25, 2019
View reviewed changes
dash/dash.py Outdated Show resolved Hide resolved
@byronz
Copy link
Contributor Author

byronz commented Sep 25, 2019

the logs will appear in CI logs only if the test case failed

alexcjohnson
alexcjohnson reviewed Sep 27, 2019
View reviewed changes
dash/dash.py Outdated Show resolved Hide resolved
alexcjohnson
alexcjohnson approved these changes Sep 27, 2019
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@byronz byronz merged commit ad982ef into dev Sep 27, 2019
@byronz byronz deleted the components-suite-logs branch September 27, 2019 17:42
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
@alexcjohnson
Merge pull request #939 from plotly/update-toolchain-20210322
3ffc50e 
Update toolchain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@Marc-Andre-Rivet Marc-Andre-Rivet Awaiting requested review from Marc-Andre-Rivet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]
2 participants
@byronz @alexcjohnson