Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async JavaScript Lazy Loading #899

Merged
merged 70 commits into from
Oct 21, 2019
Merged
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
6fbaa15
update props waits for lazy components to be ready
Aug 30, 2019
d4b56ab
lint
Aug 30, 2019
937bc30
format
Aug 30, 2019
81408b9
Merge remote-tracking branch 'origin/dev' into exp-dynamic
Sep 17, 2019
3c1620d
usage
Sep 17, 2019
d364090
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Sep 20, 2019
42f6580
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Sep 24, 2019
93cfc24
(wip) Strict 'isAppReady'
Sep 24, 2019
51b4ddf
Merge branch 'exp-dynamic' of github.com:plotly/dash into exp-dynamic
Sep 24, 2019
a70f3c2
format
Sep 24, 2019
72fe8c2
handle app ready state in store
Sep 24, 2019
3077b80
clean up
Sep 24, 2019
917f536
:loud_sound: add logs for resource serving
Sep 25, 2019
231765e
compt to py2.7
Sep 25, 2019
a387525
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Sep 26, 2019
df362a1
[WIP] Dash support for `async` flag on js_dist
Sep 26, 2019
8ee541a
lint
Sep 26, 2019
10bde03
cheat the lint...
Sep 26, 2019
96cf8f5
lint
Sep 26, 2019
659496f
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Sep 27, 2019
4e787b6
lint
Sep 27, 2019
cd1d1dc
lint
Sep 27, 2019
9429047
lint
Sep 27, 2019
cd69f6b
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Sep 27, 2019
ba03895
lazy by default, force makes eager, fix logic
Sep 27, 2019
35ba28a
lint
Sep 27, 2019
953f65b
clean up
Sep 27, 2019
610ff28
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Oct 1, 2019
b4e105a
- update app readiness on prop update
Oct 1, 2019
9d24848
Merge branch 'exp-dynamic' of github.com:plotly/dash into exp-dynamic
Oct 1, 2019
f32edbd
- share isSimpleComponent
Oct 1, 2019
91771d1
- format and redudant bool
Oct 1, 2019
58034cd
lint
Oct 1, 2019
5478f83
black / lint
Oct 1, 2019
9d95615
lint
Oct 1, 2019
2f303af
revert
Oct 1, 2019
ee608a0
revert
Oct 1, 2019
ab5801f
lint
Oct 1, 2019
be2eb1d
lint
Oct 1, 2019
c5a1636
lint (dash-renderer)
Oct 1, 2019
0a18d3c
- make `isComponentReady` part of dash-renderer
Oct 2, 2019
24712eb
standalone isComponentReady
Oct 2, 2019
37e4c9e
add project webpack-dash-dynamic-plugin
Oct 2, 2019
4daa8eb
typo
Oct 2, 2019
2c87000
lint
Oct 2, 2019
deec3d6
umd library target
Oct 2, 2019
42b62f4
changelog
Oct 2, 2019
766dad2
umd externals
Oct 2, 2019
9b06789
structure
Oct 3, 2019
99e437c
new packages
Oct 3, 2019
2650fa9
update @plotly utility packages
Oct 3, 2019
2ea2d48
update usage
Oct 3, 2019
1ce9792
changelog
Oct 3, 2019
3c3c81c
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Oct 3, 2019
af35006
update @plotly/dash-component-plugins
Oct 4, 2019
247bb64
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Oct 10, 2019
3e13e82
unit test async resources
Oct 10, 2019
884c74a
Merge branch 'exp-dynamic' of github.com:plotly/dash into exp-dynamic
Oct 10, 2019
a598dae
black
Oct 10, 2019
8d6c137
is
Oct 10, 2019
0a6e4c6
rename
Oct 10, 2019
8b864cb
e2e eager/lazy tests
Oct 10, 2019
92a5699
dcc exp-dynamic-2
Oct 11, 2019
558bf6c
cleanup
Oct 11, 2019
13e274e
use table instead of graph for devtools tests
Oct 11, 2019
1a7a470
use async table branch
Oct 11, 2019
7c3edaa
add tests for notifyObserver
Oct 11, 2019
7852312
update app ready state only for set_layout and update_props with chil…
Oct 15, 2019
063185e
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Oct 17, 2019
aa79b2f
Merge branch 'dev' into exp-dynamic
Marc-Andre-Rivet Oct 18, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dash-renderer/src/actions/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -568,8 +568,6 @@ function updateOutput(
})
);

dispatch(setAppIsReady());

return props;
}

Expand Down Expand Up @@ -917,6 +915,8 @@ function updateOutput(
);
});
}

dispatch(setAppIsReady());
alexcjohnson marked this conversation as resolved.
Show resolved Hide resolved
}
};
if (multi) {
Expand Down