Assets #597 #881
Assets #597 #881
Conversation
| @@ -27,14 +27,14 @@ def read_req_file(req_type): | |||
| long_description_content_type="text/markdown", | |||
| install_requires=read_req_file("install"), | |||
| extras_require={ | |||
| "ci": read_req_file("ci"), | |||
| "dev": read_req_file("dev"), | |||
There was a problem hiding this comment.
If we're changing ci to dev it means all projects pulling / installing dash explicitly in core will now fail. This PR needs siblings to update usage.
There was a problem hiding this comment.
dcc, has been changed
I think another one is dash-docs
There was a problem hiding this comment.
Have we publicly documented install dash[ci]? would we be better off keeping it for one minor version as "ci": read_req_file("dev") and perhaps adding a deprecation notice somewhere?
There was a problem hiding this comment.
no, ci was mainly used by circleci setup, we did mention dash[testing] though
| @@ -0,0 +1,179 @@ | |||
| # -*- coding: utf-8 -*- | |||
| from __future__ import unicode_literals | |||
There was a problem hiding this comment.
Not fully structured thoughts but I feel tying ourselves even more to Python for code generation is an anti-pattern for Dash.
While this clean up is advantageous in the short term, if we truly want to support multiple environments and not expect, say, an R or xyz developer in the future to have an environment setup for generating the other (n-1) languages / platforms supported, we should try and do our build with the only mandatory environment & language Dash requires: NodeJS
I realize I'm late in this but I don't feel fully comfortable with the direction we are taking generation towards.
There was a problem hiding this comment.
I understand the concern here, but unless we can get rid of the entire dash/development in python code. the script is created for fixing the current problem, I had no intention to hijack the JS driven direction.
There was a problem hiding this comment.
Code cleanup looks good. As mentioned here: plotly/dash-core-components#611, we'll put usage in other repos on hold for now.
Would like to see sibling PRs that modify CI usage in table / dcc / html so as to use dev instead of ci for approval.
|
@Marc-Andre-Rivet @alexcjohnson I would like to have this merge first before I create other PRs in dcc, html, and table. so I don't need to refer to this particular branch and revert it back afterwards. |
…-1.3.8 Bump ini from 1.3.5 to 1.3.8
Bump ini from 1.3.5 to 1.3.8
this PR is needed to continue wtih plotly/dash-core-components#597
mainly make the build process code more DRY, so the
buildhas a clean abstraction pipeline defined in the base class.