-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev_tools_prune_errors #860
Conversation
nearby context code is contained in the html
percy auto-approve strikes again, I suppose
@@ -15,22 +15,22 @@ | |||
"fail": True, | |||
"name": 'missing required "value" inside options', | |||
"component": dcc.Checklist, | |||
"props": {"options": [{"label": "hello"}], "values": ["test"]}, | |||
"props": {"options": [{"label": "hello"}], "value": ["test"]}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what infuriates me about Percy... OK, here it's just a test problem, not a real bug, but the images were completely different from what they should have been, and got auto-approved, I assume, because the change came from DCC and so likely happened first in master.
skip = 0 | ||
for i, line in enumerate(tb.plaintext.splitlines()): | ||
if "%% callback invoked %%" in line: | ||
skip = int((i + 1) / 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the skip is about half of code to the callback stub? just curious about the algorithm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plaintext traceback has 2 lines for each stack frame: first line lists the file, line #, and function; second line is the actual line of code. +1 gives the first line of the next pair - the first frame we want to report - then /2 gives the number of frames above it.
Co-Authored-By: Byron Zhu <byronz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
…dlebars-4.7.6 Bump handlebars from 4.1.1 to 4.7.6
…s-4.7.6 Bump handlebars from 4.1.1 to 4.7.6
Closes #843
Adds a new
run_server
/enable_dev_tools
argdev_tools_prune_errors
that defaults toTrue
. In that default case, tracebacks only include user code (and anything below it in the stack), excluding entries from Dash and Flask. Set it toFalse
to revert to the current behavior of showing the complete stack.