-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashr test support #827
Dashr test support #827
Conversation
@rpkyle @Marc-Andre-Rivet I need a review on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 LGTM!
else os.path.join( | ||
(os.getenv("TEMP"), "app_{}.R".format(uuid.uuid4().hex)) | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this will work, but it doesn't remove the file afterward, does it? Would there have been a way to do this with tmpdir
? Not sure how to go about using one fixture from within the definition of another, but it feels like all the edge cases and cleanup have already been sorted out there.
This fixes #826
the app as string sample
the filepath version