Fix callback error reporting #821
Conversation
| ) | ||
| except WebDriverException: | ||
| if not i: | ||
| raise |
There was a problem hiding this comment.
@byronz I had 3 failures this morning - all from different tests, but with the same message:
WebDriverException: Message: unknown error:
Chrome failed to start: exited abnormally
(unknown error: DevToolsActivePort file doesn't exist)
It's a bit icky to add a blind retry loop like this, but it seemed to work.
There was a problem hiding this comment.
I had an impression this crash comes always from one specific python version, like 3.7, or 2.7. Might be good to figure out the real root cause, but assuming it's just turbulence from the circleci docker. it's more related to bad timing due to load performance of the selenium server. should we try another approach like the wait.until? with a reasonable small wait time like 0.1s, I believe the next try should work (we can give a more tolerant 1s timeout).
There was a problem hiding this comment.
@alexcjohnson I created another PR to fix the deprecated message with pytest.raises, and I formatted the file with black. so if you can format this test_integration file in this PR, we could avoid a lot potential merge conflicts.
There was a problem hiding this comment.
I saw this in both 2.7 and 3.7. Feel free to dig in more (preferably in another PR so we can get this bugfix merged), but it's not clear to me what we could wait for, seems like this is happening deep inside Selenium.
There was a problem hiding this comment.
agree, we can leave it now in this PR.
|
|
||
| with pytest.raises(NonExistentIdException) as err: | ||
| @app.callback( | ||
| Output('nuh-uh', 'children'), |
There was a problem hiding this comment.
minor: might be slightly better with a multi-output edge case?
There was a problem hiding this comment.
added multi-output in fbec9dc
#753 simplified the base
Componentclass to prohibit fewer prop names - but thekeysmethod was actually being used, leading to #791. Easy to replace it with a list comprehension (which calls__iter__under the hood).CHANGELOG.md