Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version lock for the core components libraries #565

Merged
merged 5 commits into from
Feb 1, 2019
Merged

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Feb 1, 2019

Added the core libraries to setup.py install_requires, installing dash will now also install:

  • dash-core-components
  • dash-html-components
  • dash-table

Closes #564

@T4rk1n T4rk1n requested a review from alexcjohnson February 1, 2019 20:23
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Please merge once you've figured out how this will impact CI testing in the core packages. 💃

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Feb 1, 2019

Ok, so after testing, no need to install the local package with develop mode on circle, it will take the local folder for the package.

@T4rk1n T4rk1n merged commit d2c9a9c into master Feb 1, 2019
@T4rk1n T4rk1n deleted the version-lock branch February 1, 2019 22:27
HammadTheOne pushed a commit to HammadTheOne/dash that referenced this pull request May 28, 2021
HammadTheOne pushed a commit that referenced this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants