-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use all python keywords when checking if prop name is valid #450
Conversation
I thought those tests failures were resolved by 9e3ca4d. Or are they new failures ? |
I'm not really sure, been trying to figure it out. I'm not getting those errors locally |
Locally I get this... strange
|
Fails for me too, that file is not tested on ci, maybe it's old ? |
Oh ok I'm using |
Try locking |
Cool. Looks like |
Yes, there is this bug plotly/dash-core-components#362, thought it was fixed in plotly/dash-core-components#356 but I guess it just made it worse. I have a test that fails in the conditions, I tried on one version of the commits and it passed. but after merge it failed again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 I think we need those Input integration test in the dcc repo instead of here so the failures happens there instead.
Solves #361
Previously, we did not allow a prop name to be written as a keyword argument in a Python Component class if it was in
keyword.kwlist
. Sincekeyword.kwlist
is version specific, class files were dependent on the Python version used to create them.This PR removes this problem, Python Component class files built with any of our supported versions (2.7, 3.3, 3.4, 3.5, 3.6, 3.7) should work for all the other ones too.
Note that these props are still usable, they are just passed through
**kwargs
rather than a proper keyword argument, so IDEs will not autocomplete for these props.async
inhtml.Script
is the only component in the core libraries affected by this so far.