Prefix assets with requests_pathname_prefix.
#351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add a test? Otherwise 💃 |
T4rk1n
force-pushed
the
assets-requests-prefix
branch
from
393f137 to
b4a4ce9
Compare
|
I added a test and found out that it was not working as expected in some cases, thanks. |
ned2
approved these changes
Aug 27, 2018
|
Looks good to me 💃 |
T4rk1n
force-pushed
the
assets-requests-prefix
branch
from
b4a4ce9 to
b815c39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #349, the assets were not prefixed with the
requests_pathname_prefixresulting in 404 on the dash deployment server.get_asset_urlmethod to dash, retrieve the url of an asset by it's filename (eg:app.get_asset_url('style.css')will return/assets/style.css), it is automatically prefixed withrequests_pathname_prefix.