Add meta http-equiv for ie compatibility to the index by default. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's follow the lead on this project: |
chriddyp
approved these changes
Aug 1, 2018
T4rk1n
force-pushed
the
ie-compat-meta-tag
branch
from
f6797db to
0b3b55c
Compare
|
@T4rk1n - Could we add this item to the changelog? |
|
@chriddyp - It is in the changelogs: https://github.com/plotly/dash/blob/master/CHANGELOG.md#0231---2018-08-02 |
|
🙈 sorry about that, totally missed it. thank you! 🙇 |
ngnpope
reviewed
Oct 2, 2018
| has_charset = any('charset' in x for x in self._meta_tags) | ||
|
|
||
| tags = [] | ||
| if not has_ie_compat: | ||
| tags.append('<meta equiv="X-UA-Compatible" content="IE=edge">') |
There was a problem hiding this comment.
Hmm. Should this be http-equiv="..."?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #275, add
<meta http-equiv="X-UA-Compatible" content="IE=8">to the index if it's not specified in themeta_tags.Should the meta tags be closed with '
/>or just>? The HTML5 specification says it doesn't need it but it's needed byxhtml. We have<!DOCTYPE html>by default, but if someone changes it to something else it might needs it.