Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Graph component becomes unresponsive if an invalid figure is passed #3103

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Bugfix: Graph component becomes unresponsive if an invalid figure is passed #3103

merged 3 commits into from
Dec 11, 2024

Conversation

KoolADE85
Copy link
Contributor

@KoolADE85 KoolADE85 commented Dec 11, 2024 •
edited
Loading

This PR fixes a bug where a Graph with an invalid figure prop (for example, figure=None) would remain broken even after being updated to a valid figure.

See the integration test for an example Dash app that is fixed here.

Fixes https://github.com/plotly/notebook-to-app/issues/2065

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@KoolADE85 KoolADE85 force-pushed the bugfix/graphs-with-empty-figure branch from a620a16 to 2a640fb Compare December 11, 2024 01:30
T4rk1n
T4rk1n approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good, just add a changelog entry.

@KoolADE85 KoolADE85 merged commit 7ba267b into dev Dec 11, 2024
3 checks passed
@sourcery-ai sourcery-ai bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson gvwilson is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KoolADE85 @T4rk1n