Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds id to dcc.Loading DOM #2888

Merged
merged 3 commits into from
Jun 18, 2024
+5 −3
Merged

Adds id to dcc.Loading DOM #2888

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e27cae3
Adds id to dcc.Loading DOM
leeagustin Jun 15, 2024
9dcf243
Moves dcc.Loading's DOM id to outer div
leeagustin Jun 18, 2024
ca5d66a
Modifies loading component test to include id
leeagustin Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions components/dash-core-components/src/components/Loading.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const Loading = ({
loading_state,
display,
color,
id,
className,
style,
parent_className,
Expand Down Expand Up @@ -148,6 +149,7 @@ const Loading = ({
{showSpinner &&
(custom_spinner || (
<Spinner
id={id}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id should be on the outer div, the spinners https://github.com/plotly/dash/blob/4692acf61f3e282950a8d1014b152176addb2aec/components/dash-core-components/src/fragments/Loading/spinners/ don't have the id prop so it wouldn't render on the DOM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, good catch 😄

Changed in 9dcf243

className={className}
style={style}
status={loading_state}
Expand Down