Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dropdown css #2880

Closed
wants to merge 3 commits into from
Closed

fix dropdown css #2880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c770e0
fix dropdown css
AnnMarieW Jun 10, 2024
aa1df38
Added changelog
AnnMarieW Jun 10, 2024
e7174a2
rerun tests
AnnMarieW Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
## UNRELEASED

## Fixed

- [#2880](https://github.com/plotly/dash/pull/2860) Fix Ensure dcc.Dropdown options maxHeight works with Datatable . Fixes [#2529](https://github.com/plotly/dash/issues/2529) [#2225](https://github.com/plotly/dash/issues/2225)
- [#2860](https://github.com/plotly/dash/pull/2860) Fix dcc.Loading to apply overlay_style only to the children and not the spinner. Fixes [#2858](https://github.com/plotly/dash/issues/2858)
- [#2854](https://github.com/plotly/dash/pull/2854) Fix dcc.Dropdown resetting empty values to null and triggering callbacks. Fixes [#2850](https://github.com/plotly/dash/issues/2850)
- [#2859](https://github.com/plotly/dash/pull/2859) Fix base patch operators. fixes [#2855](https://github.com/plotly/dash/issues/2855)
Expand Down
3 changes: 2 additions & 1 deletion components/dash-core-components/src/components/css/Dropdown.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
.dash-dropdown .Select-menu-outer {
z-index: 1000;
max-height: none;
}

.dash-dropdown .Select-menu, .Select-menu-outer {
.dash-dropdown .Select-menu {
max-height: none;
}
5 changes: 4 additions & 1 deletion components/dash-core-components/tests/integration/dropdown/test_visibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ def test_ddvi001_fixed_table(dash_duo):
def test_ddvi002_maxHeight(dash_duo):
app = Dash(__name__)
app.layout = Div(
[Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800)]
[
DataTable(), # ensure datatable css does not override maxHeight #2529
Dropdown([str(i) for i in range(100)], "1", id="dropdown", maxHeight=800),
]
)

dash_duo.start_server(app)
Expand Down