Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper bound on Flask and Werkzeug versions #2538

Merged
merged 9 commits into from
May 24, 2023
Merged

Upper bound on Flask and Werkzeug versions #2538

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e190d37
upper bound on Flask and Werkzeug versions
alexcjohnson May 23, 2023
8797787
changelog for limiting Flask & Werkzeug
alexcjohnson May 23, 2023
75f3d33
update html generation
alexcjohnson May 23, 2023
c25225b
update changelog per Jessica's suggestion
alexcjohnson May 23, 2023
d1349fa
update js deps in dash.html
alexcjohnson May 23, 2023
4892b21
dep updates for dcc, including plotlyjs 2.23.2
alexcjohnson May 23, 2023
1eb49a8
update dash-table deps, and adapt code for new TS errors
alexcjohnson May 23, 2023
b750c15
update js dependencies in renderer
alexcjohnson May 23, 2023
9ece9a3
udpate js deps in dash, and changelog entry for all js dep updates
alexcjohnson May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](https://semver.org/).

## [UNRELEASED]

## Changed

- [#2538](https://github.com/plotly/dash/pull/2538) Add an upper bound to Flask and Werkzeug versions at `<2.2.3`, to reflect the fact that we expect the Dash ecosystem to be incompatible with the next minor release of Flask. This excludes the current latest Flask release 2.3.x, we will raise that to `<2.4` after we fix incompatibilities elsewhere in the Dash ecosystem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking but there's a comma splice in the second sentence. I'd suggest different punctuation, but it's not clear to me how the two clauses relate to each other―if they don't really, maybe something like

Add an upper bound to Flask and Werkzeug versions at <2.2.3 because we expect the Dash ecosystem to be incompatible with the next minor release of Flask (this excludes the current latest Flask release 2.3.x). We will raise the upper bound to <2.4 after we fix incompatibilities elsewhere in the Dash ecosystem.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in c25225b - thanks @red-patience!


## Fixed

- [#2508](https://github.com/plotly/dash/pull/2508) Fix error message, when callback output has different length than spec
Expand Down
3 changes: 2 additions & 1 deletion requires-install.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Flask>=1.0.4
Flask>=1.0.4,<=2.2.3
Werkzeug<=2.2.3
plotly>=5.0.0
dash_html_components==2.0.0
dash_core_components==2.0.0
Expand Down