Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both 400 and 401 for JWT expiry responses #2098

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Jun 17, 2022

As in my comment in the code: Some servers use code 400 for expired tokens, because they reserve 401 for cases that require user action.

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR
  • I have added entry in the CHANGELOG.md

@alexcjohnson alexcjohnson requested a review from T4rk1n June 17, 2022 19:55
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💃

@@ -196,7 +196,7 @@ def _set_random_id(self):
"""
)

v = str(uuid.UUID(int=rd.randint(0, 2 ** 128)))
v = str(uuid.UUID(int=rd.randint(0, 2**128)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to look into whether we're linting correctly on CI - this was caught by the precommit hook for me 🤷

@alexcjohnson alexcjohnson merged commit ac7b37d into dev Jun 17, 2022
@alexcjohnson alexcjohnson deleted the flex-jwt-expiry branch June 17, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants