Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table incorrect highlight #1968

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Fix table incorrect highlight #1968

merged 4 commits into from
Apr 22, 2022

Conversation

nickmelnikov82
Copy link
Member

@nickmelnikov82 nickmelnikov82 commented Mar 14, 2022 •
edited
Loading

As described in issue #1877 code which uses merge_duplicate_headers and style_header_conditional to highlight columns, it incorrectly highlights header cells. The problem is in the wrong mapping between styles array and merged cells array.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • fix style mapping
    • add test
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

T4rk1n
T4rk1n approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks good to me.

@alexcjohnson
Copy link
Collaborator

Excellent, thanks for reviewing @T4rk1n!

@nickmelnikov82 please add a changelog entry, and we'll merge.

@nickmelnikov82 nickmelnikov82 force-pushed the fix/style-header-conditional branch 2 times, most recently from d9a7a66 to a5983c1 Compare April 15, 2022 07:34
@nickmelnikov82 nickmelnikov82 force-pushed the fix/style-header-conditional branch from a5983c1 to d5b0aff Compare April 21, 2022 08:38
@alexcjohnson alexcjohnson merged commit a392f73 into plotly:dev Apr 22, 2022
This was referenced Apr 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson alexcjohnson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickmelnikov82 @alexcjohnson @T4rk1n