Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph customdata for pointnumbers #1942

Merged

Conversation

nickmelnikov82
Copy link
Member

@nickmelnikov82 nickmelnikov82 commented Feb 22, 2022

Fix #1663 - clickData for graph pie charts has pointNumbers but not customdata.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Fix issue
    • Make test
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Lovely fix, and excellent test! I'm preparing for a release now, will add a changelog entry for this as I do that.

@alexcjohnson alexcjohnson merged commit 228010d into plotly:dev Mar 13, 2022
@nickmelnikov82 nickmelnikov82 deleted the fix-graph-customdata-for-pointnumbers branch March 14, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] customdata is missing in clickData for pie charts
2 participants