Serialization and Percy updates #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than a built-in error because it had its own problem!
3.5.4 is the last version supporting py3.6 3.6.3 is current and supports py3.7+
- when a job modifies env vars, it must recreate all of them - single big workflow - drop some unused build steps - there's still more to do here. - some merge keys had the same names. that's technically OK but fragile, so made unique - standardized indentation
alexcjohnson
force-pushed
the
multi-error
branch
from
c0a3500 to
7e689fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some issues discovered in updating DDK
The version of
orjsonwe were including in[dev]in Py3.6 has problems with numpy string (dtype=object) arrays. Not sure why we pinned this version, but bumping to the latest for each Python minor fixes this.Cleaned up our error handling of serialization problems
Fixed our percy builds, so we only get one per project: one in dash, one in dash-table-test. Along the way I refactored the circleci config into one big workflow and removed some unnecessary jobs.
Reduced the number of percy snapshots we take for the table (only one width - we do so much in JS that there's no point having multiple widths on Percy's side), and added the ability for
dash.testingpercy_snapshotmethods to choose widths to generate.I have added entry in the
CHANGELOG.md