Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Julia components with nested structure #1453

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

tcbegley
Copy link
Contributor

@tcbegley tcbegley commented Nov 7, 2020

This PR allows generation of Julia components with nested structure, it is based on #1203 which did the same for R components. This change will allow me to bring Julia support to dash-bootstrap-components.

As far as I could see there wasn't an obvious place to add tests for this. Happy to take a stab at that if you point me to where I should do that.

@tcbegley
Copy link
Contributor Author

tcbegley commented Jan 6, 2021

Hello, and happy new year!

Just want to check in on this as it's been a while. No particular rush to get anything merged, but it would be helpful to at least know in principle whether you are willing to make a change like this or if I should look for workarounds? I figured since it is simply bringing parity to R and Julia component generation it shouldn't be too controversial?

@alexcjohnson alexcjohnson requested a review from rpkyle as a code owner January 6, 2021 15:53
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy New Year @tcbegley! Thanks for the PR and apologies for missing this earlier. We have a project lingering in the background to redo component generation in JS (node) rather than Python, which may be why this PR dropped off our radar. But that effort has been put on hold for a while so let's move ahead with this PR. I'm Assuming you've used it on your project and the Julia package works as expected? If so I don't think we need any explicit tests at this time. 💃

@tcbegley
Copy link
Contributor Author

tcbegley commented Jan 6, 2021

apologies for missing this earlier

No worries at all

We have a project lingering in the background to redo component generation in JS (node) rather than Python

Oh cool, sounds like an interesting idea!

I'm Assuming you've used it on your project and the Julia package works as expected?

Yep, seems to be all good this end.

@alexcjohnson alexcjohnson merged commit cab1262 into plotly:dev Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants