Improve error message on components with invalid prop names #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriddyp
requested review from
alexcjohnson and
Marc-Andre-Rivet
as code owners
4 tasks
|
Slight sizing issue in Percy which I'm assuming is irrelevant |
|
Tests are passing now 🎉 |
alexcjohnson
reviewed
Jan 8, 2020
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ### Fixed | |||
| - [#1037](https://github.com/plotly/dash/pull/1037) Fix no_update test to allow copies, such as those stored and retrieved from a cache. | |||
| - [#1074](https://github.com/plotly/dash/pull/1045) Error messages when providing an incorrect property to a component have been improved: they now specify the component type, library, version, and ID (if available). | |||
There was a problem hiding this comment.
Not a big deal, but I wouldn't call this "Fixed", I'd call it "Changed." Fixed should refer to bugs only.
yeah that one has been doing that forever. would be great to figure out why and 🔒 it, but somehow the cause wasn't obvious to me last time I looked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1045 but rebased off of
dev