Simplify build #1035
Simplify build #1035
Conversation
hmm, to actually make that happen I'd have to also edit |
| } | ||
| } | ||
| return errors.join('\n\n'); | ||
| } |
There was a problem hiding this comment.
Since the original file is under a BSD license, we should make sure that we either retain the original disclaimer as done in check-prop-type (https://github.com/ratehub/check-prop-types/blob/master/index.js#L7) or make sure the disclaimer for React is included explicitly in our bundled code -- which it wouldn't right now as we externalize React dependencies.
There was a problem hiding this comment.
Current prop-types license is MIT (it was changed from BSD shortly after check-prop-types was published), as is check-prop-types - that presumably means this concern is moot, yes?
There was a problem hiding this comment.
Moot as moot can be
|
One licensing comment for check-prop-types, otherwise 👍 |
A few changes to get our webpack config a little more manageable...
raw-loaderwas only used for the werkzeug css - I just wrapped that in js to export a string explicitly.uniqidwasn't even being used, AFAICT. We were generating them and ignoring them. Probably was intended at some point for being able to clear errors. But that's something we've removed the vestiges of, at least for the time being. This is one more.check-prop-typeshasn't been maintained recently, and anyway if given the opportunity (by bringing it into our own src) we would make some slightly different choices anyway - the one I made already was returning all prop errors, not just the first one.